Bug #222

wrong vnc password elemnent in the resulting XML

Added by Shi Jin almost 9 years ago. Updated almost 9 years ago.

Status:ClosedStart date:04/27/2010
Priority:NormalDue date:
Assignee:Ruben S. Montero% Done:

0%

Category:Core & System
Target version:Release 1.4.2
Resolution:fixed Pull request:
Affected Versions:

Description

When I specify in my OpenNebula template

GRAPHICS = [ type = "vnc",passwd="password123" ]

The resulting deployment.0 XML for libvirt shows
<graphics type='vnc' password='password123'/>

This is a bug since according to http://libvirt.org/formatdomain.html, it should be
<graphics type='vnc' passwd='password123'/>

Note it is passwd instead of password.

I've already tested it to confirm that with this change, the password is required to login to the VNC session.

Thanks.

Associated revisions

Revision 0029dd40
Added by Ruben S. Montero almost 9 years ago

bug #222: Wrong VNC attributes. Patch Contributed by Shi Jin.

Revision 318306c4
Added by Ruben S. Montero almost 9 years ago

bug #222: Wrong VNC attributes. Patch Contributed by Shi Jin.

Revision 8589b84a
Added by Juan Jose Montiel Cano about 2 years ago

Feature 5058 (#222)

  • F #5058
    - Added new panel for system
    - hided images and added link for show these images
  • Added OPENNEBULA attribute in creation group

History

#1 Updated by Shi Jin almost 9 years ago

Fix is easy:

diff --git a/src/vmm/LibVirtDriver.cc b/src/vmm/LibVirtDriver.cc
index 394d218..af0d935 100644
--- a/src/vmm/LibVirtDriver.cc
+++ b/src/vmm/LibVirtDriver.cc
@@ -434,7 +434,7 @@ int LibVirtDriver::deployment_description(

                 if ( !passwd.empty() )
                 {
-                    file << " password='" << passwd << "'";
+                    file << " passwd='" << passwd << "'";
                 }

                 if ( !keymap.empty() )

#2 Updated by Ruben S. Montero almost 9 years ago

  • Category set to Core & System
  • Status changed from New to Closed
  • Assignee set to Ruben S. Montero
  • Target version set to Release 1.4.2
  • Resolution set to fixed

I've commited this to master and one-1.4 branches. THANKS for the patch!

Also available in: Atom PDF