Bug #4376

Automatically assigned VLAN ID can produce invalid values for 802.1Q tags

Added by Jamie Taylor over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:03/17/2016
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Drivers - Network
Target version:Release 5.0
Resolution:fixed Pull request:
Affected Versions:OpenNebula 4.14

Description

An automatically assigned VLAN ID is calculated by adding a constant to the network id, in vlan.rb:120

@nic[:vlan_id] = CONF[:start_vlan] + network_id

802.1Q VLAN IDs are limited to the values 0x001 through 0xFFE, whereas network_id has no such restriction. Repeated creation and deletion of virtual network will eventually result in assigning an invalid VLAN ID.

VLAN ID assignment should be decoupled from the network ID, and the assignment algorithm should be able to reuse previously allocated IDs after the owning network has been deleted. The user should also be able to specify an upper bound for the IDs to be allocated, as described in #3298.

Here is a concrete use case where the current behavior is an issue:
A continuous integration system dynamically creates new testbeds. Each testbed is new VMs on a new virtual network with its own VLAN, thus isolated from all other testbeds. After a test run is complete, the testbed VMs and virtual network are deleted.

Associated revisions

Revision a9f8dbd1
Added by Ruben S. Montero over 3 years ago

feature #3858, #4376: Remove vlan_id generation from drivers. Remove
VLAN=YES checks that were left behind...

Revision e4db6af0
Added by Jaime Melis over 3 years ago

Bug #4376: Fix typo

Revision 5bd27d08
Added by Jaime Melis over 3 years ago

Bug #4376: Reserve also VLAN_ID 1, and fix typo in oned.conf

Revision f1b56ed3
Added by Jaime Melis over 3 years ago

Bug #4376: Make vlan_id_automatic a top level attribute
and only allow modification of vlan_id if vlan_id_automatic
is set to false (the vlan_id has been specified manually)

Revision 0cac5579
Added by Jaime Melis over 3 years ago

Bug #4376: Migrator for VLAN_ID and VLAN_ID_AUTOMATIC

Revision 9c362e4e
Added by Jaime Melis over 3 years ago

Bug #4376: migrator of the vlan_bitmap table

Revision 28e390ce
Added by Jaime Melis over 3 years ago

Bug #4376: Make the VN_MAD selection interactive

Revision bc41f6af
Added by Jaime Melis over 3 years ago

Bug #4376: Remove vnmad.rb onedb patch

It is not necessary any more as the VN_MAD selection
is interactive.

History

#1 Updated by Ruben S. Montero over 3 years ago

  • Category set to Drivers - Network
  • Target version set to Release 5.0

#2 Updated by Ruben S. Montero over 3 years ago

  • Status changed from Pending to Closed
  • Resolution set to fixed

Also available in: Atom PDF