Bug #2683

Template wizard breaks attributes with '&' on update

Added by Boris Parak about 6 years ago. Updated about 6 years ago.

Status:ClosedStart date:01/27/2014
Priority:NormalDue date:
Assignee:Daniel Molina% Done:

100%

Category:Sunstone
Target version:Release 4.6
Resolution:fixed Pull request:
Affected Versions:OpenNebula 4.4

Description

VM template wizard will replace every '&' with '&' on load and break the virtual machine template. Escaping is also broken, '&' will be escaped as '&' on next load and this will happen again and again ...

Advanced mode is working fine.

Associated revisions

Revision 8ba6d328
Added by Daniel Molina about 6 years ago

bug #2683: Template wizard breaks attributes with '&' on update

Revision 0e11f814
Added by Daniel Molina about 6 years ago

bug #2683: htmlDecode custom vars

History

#1 Updated by Ruben S. Montero about 6 years ago

  • Status changed from Pending to New
  • Target version set to Release 4.6

#2 Updated by Boris Parak about 6 years ago

Boris Parak wrote:

VM template wizard will replace every '&' with '&' on load and break the virtual machine template. Escaping is also broken, '&' will be escaped as '&' on next load and this will happen again and again ...

Advanced mode is working fine.

(to clarify stuff lost in HTML)

& -> &

& -> & -> & ->*

And a small update. There is a similar problem with escaped quotes ' \" ' in values. Here is an example:

ATTR = "thisIsValue=\"thisIsStillValue\""

#3 Updated by Ruben S. Montero about 6 years ago

OK, Thanks for the detailed report!

#4 Updated by Daniel Molina about 6 years ago

  • Assignee set to Daniel Molina

#5 Updated by Daniel Molina about 6 years ago

Hi Boris,

This patch should fix the problem, let me know if it works for you
Revision 8ba6d328

#6 Updated by Boris Parak about 6 years ago

Daniel Molina wrote:

Hi Boris,

This patch should fix the problem, let me know if it works for you
Revision 8ba6d328

Hi Daniel,

quotes are working nicely, however ampersands (&) are still broken.

Cheers, Boris

#7 Updated by Daniel Molina about 6 years ago

Now it should work for custom vars, which I guess it's what you're using

#8 Updated by Boris Parak about 6 years ago

Daniel Molina wrote:

Now it should work for custom vars, which I guess it's what you're using

I will test it ASAP and let you know. We had a big problem with REQUIREMENTS in older templates (from previous versions of ONE, before you started using SCHED_REQUIREMENTS).

#9 Updated by Boris Parak about 6 years ago

Works, thanks!

#10 Updated by Daniel Molina about 6 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100
  • Resolution set to fixed

Great!, thank you for your feedback

Also available in: Atom PDF