Bug #3745

onedb fsck rejects passwords based on undocumented syntax rules

Added by Bill Cole over 5 years ago. Updated about 5 years ago.

Status:ClosedStart date:04/09/2015
Priority:NormalDue date:
Assignee:Jaime Melis% Done:

0%

Category:CLI
Target version:Release 4.14
Resolution:fixed Pull request:
Affected Versions:Development, OpenNebula 2.2, OpenNebula 3.0, OpenNebula 3.2, OpenNebula 3.4, OpenNebula 3.6, OpenNebula 3.8, OpenNebula 4.0, OpenNebula 4.10, OpenNebula 4.12, OpenNebula 4.2, OpenNebula 4.4, OpenNebula 4.6, OpenNebula 4.8

Description

For example, with the password 'zyna3=%-raleaSe' :

   # onedb fsck -v -S localhost -u oneadmin  -d opennebula
   MySQL Password: 
   Error connecting to DB: bad URI(is not URI?): mysql://oneadmin:zyna3=%-raleaSe@localhost:0/opennebula

If you're going to use an undocumented non-standard URI scheme internally to pass authentication information, you should at least follow the normal rules for constructing URI's: percent-encode the userinfo parts as needed when constructing the URI and decode them when interpreting the URI. Or better yet, dump the pointless artifice of a 'mysql:' URI scheme here altogether.

Associated revisions

Revision c2a6c673
Added by Jaime Melis about 5 years ago

Bug #3745: encode password to allow all chars

History

#1 Updated by Bill Cole over 5 years ago

This problem also occurs with "onedb upgrade" in version 4.12.1

#2 Updated by Carlos Martín over 5 years ago

  • Category set to CLI
  • Status changed from Pending to New
  • Target version set to Release 4.14

Hi,

This is a known issue. Although it's documented in the upgrade docs, but not in the fsck guide.

I'll schedule it for 4.14 to take a look and update the docs. Last time we checked, it was a problem with the ruby gem we use to connect to the DB, and it couldn't be fixed from our side.

#3 Updated by Ruben S. Montero about 5 years ago

  • Assignee set to Jaime Melis

#4 Updated by Jaime Melis about 5 years ago

  • Status changed from New to Closed
  • Resolution set to fixed
  • Affected Versions Development, OpenNebula 2.2, OpenNebula 3.0, OpenNebula 3.2, OpenNebula 3.4, OpenNebula 3.6, OpenNebula 3.8, OpenNebula 4.0, OpenNebula 4.12, OpenNebula 4.2, OpenNebula 4.4, OpenNebula 4.6, OpenNebula 4.8 added

Also available in: Atom PDF