Bug #3953

ceph: monitor script doesn't monitor pool space but total space

Added by Laurent Grawet about 5 years ago. Updated over 4 years ago.

Status:ClosedStart date:08/27/2015
Priority:NormalDue date:
Assignee:Jaime Melis% Done:

100%

Category:Drivers - Storage
Target version:Release 5.0.1
Resolution: Pull request:
Affected Versions:OpenNebula 5.0

Description

Hi,

The ceph monitor script doesn't monitor pool space but total space.
Here is a patch for the monitor script. The script is now parsing the xml output of "ceph df" instead of "rados df"

Best regards,

Laurent

ceph-monitor.path - ceph pool monitoring patch (1.77 KB) Laurent Grawet, 08/27/2015 11:50 AM

ceph-monitor.patch Magnifier - ceph pool monitoring patch: removed comments (1.52 KB) Laurent Grawet, 08/27/2015 12:01 PM

Associated revisions

Revision a87b4db4
Added by Laurent Grawet over 4 years ago

Backlog #3953: "ceph df" XML output parsing for the monitor script (#103)

Thanks. MUCH more cleaner and safer now :+1:

Revision 27e152c2
Added by Ruben S. Montero over 4 years ago

bug #3953: Better ceph df parsing. Apply changes to Ceph System DS also

History

#1 Updated by Laurent Grawet about 5 years ago

Sorry but there were a few commented lines left out for testing purposes.
Here is an updated patch, you can discard the first file.

#2 Updated by Laurent Grawet about 5 years ago

  • % Done changed from 0 to 100

#3 Updated by Ruben S. Montero about 5 years ago

  • Assignee set to Jaime Melis

#4 Updated by Jaime Melis about 5 years ago

  • Tracker changed from Bug to Backlog
  • Target version changed from Release 4.14 to Release 5.0

Laurent, the current code now in master already uses "ceph df" and not "rados df". This was fixed by:
https://github.com/OpenNebula/one/commit/7d4226caaa9574df3c7c37a4a95c73c2bbf05df7

https://github.com/OpenNebula/one/blob/master/src/datastore_mad/remotes/ceph/monitor#L86

I do like your idea of using the XML output, but for this release we are going to leave it as is.

Changing to backlog for release 5.0.

#5 Updated by Stefan Kooman about 5 years ago

I would like to add something to this. OpenNebula does not take into account the amount of space it is allowed to use, i.e.: quota.

ceph osd pool get-quota one

quotas for pool 'one':
max objects: N/A
max bytes : 1024GB

If no quota is set, assume OpenNebula is allowed to use MAX AVAIL, otherwise honour quota.

#6 Updated by Ruben S. Montero almost 5 years ago

  • Target version deleted (Release 5.0)

#7 Updated by Ruben S. Montero over 4 years ago

  • Tracker changed from Backlog to Bug
  • Status changed from Pending to Closed
  • Target version set to Release 5.2
  • Affected Versions OpenNebula 5.0 added

Merged the pull request. Also used in System DS ceph.

#8 Updated by Ruben S. Montero over 4 years ago

  • Target version changed from Release 5.2 to Release 5.0.1

Also available in: Atom PDF