Bug #447

If mkfs is not found, image files are left in the repository

Added by Carlos Martín over 10 years ago. Updated about 10 years ago.

Status:ClosedStart date:12/14/2010
Priority:NormalDue date:
Assignee:Javi Fontan% Done:

0%

Category:CLI
Target version:Release 2.2
Resolution:fixed Pull request:
Affected Versions:

Description

Registering a datablock image in the repository:
If mkfs is not found, the Image is not registered into the pool, but the file is left in the repository.

$ which mkfs
/usr/bin/which: no mkfs in (...)

$ cat datablock.one 
   NAME          = "storage" 
   TYPE          = DATABLOCK
   PERSISTENT    = YES
   SIZE          = 10
   FSTYPE        = ext3

$ oneimage register datablock.one
Error: mkfs Image: in mkfs command.

$ tree var/images/
var/images/
`-- e50d44a16247b5caf2a0d841f5fad778ad38dbeb

Associated revisions

Revision c93991f0
Added by Carlos Martín about 10 years ago

Bug #447: 'oneimage register' now has some extra error checks and file cleanup.

Revision 3babd9a4
Added by Ruben S. Montero about 10 years ago

bug #447: Also removes file if cp fails

Revision b0e4edc3
Added by Carlos Martín about 10 years ago

Bug #447: 'oneimage register' now has some extra error checks and file cleanup.
(cherry picked from commit c93991f0c49ad8434f82841ae4c8c547ddc268a5)

Revision 0721c833
Added by Ruben S. Montero about 10 years ago

bug #447: Also removes file if cp fails
(cherry picked from commit 3babd9a405925b6502faa0d09e2c7a8e667c2ea7)

History

#1 Updated by Carlos Martín over 10 years ago

  • Subject changed from If mkfs in not found, image files are left in the repository to If mkfs is not found, image files are left in the repository

#2 Updated by Ruben S. Montero about 10 years ago

  • Target version set to Release 2.2

#3 Updated by Carlos Martín about 10 years ago

Apart from the original bug, another one was found and solved:
Image templates with a non-existing path were left in the repository as disabled, instead of being deleted.

#4 Updated by Ruben S. Montero about 10 years ago

  • Status changed from New to Closed
  • Resolution set to fixed

Solved in master

Also available in: Atom PDF