Bug #4687

Uploading gzip files with no tar in vcenter DS should fail gracefully

Added by Tino Vázquez almost 5 years ago. Updated over 4 years ago.

Status:ClosedStart date:09/30/2016
Priority:NormalDue date:10/07/2016
Assignee:MIGUEL ANGEL ALVAREZ CABRERIZO% Done:

100%

Category:vCenter
Target version:Release 5.2
Resolution:fixed Pull request:
Affected Versions:Development

Description

Or be supported

Associated revisions

Revision 3669fe7c
Added by Miguel Ángel Álvarez Cabrerizo over 4 years ago

B #4687: Uploading gzip files with no tar in vcenter DS should fail gracefully

Revision b58ae679
Added by Miguel Ángel Álvarez Cabrerizo over 4 years ago

B #4687: Uploading gzip files with no tar in vcenter DS should fail gracefully

Revision 1151843d
Added by Tino Vázquez over 4 years ago

Merge pull request #121 from n40lab/B4687

B #4687: Uploading gzip files with no tar in vcenter DS should fail gracefully

History

#1 Updated by Tino Vázquez almost 5 years ago

  • Status changed from New to Closed
  • Assignee set to Tino Vázquez
  • % Done changed from 0 to 100
  • Resolution set to worksforme

Tested both tar.gz and gz and working as expected

#2 Updated by Tino Vázquez almost 5 years ago

  • Status changed from Closed to New

Reopening since needs further testing

#3 Updated by Miguel Ángel Álvarez Cabrerizo almost 5 years ago

  • Due date set to 10/03/2016
  • Status changed from New to Closed
  • Start date changed from 07/26/2016 to 09/30/2016

Tested on master branch.

- Registering plain VMDK standalone file. Working.
- Registering VMDK standalone file zipped with GZIP. Working.
- Registering VMDK standalone file tar and gzipped. Working.
- Registering VMDK flat and descriptor files inside a tar gzipped file. Working.

Apparently all works out of the box in master branch.

#4 Updated by Tino Vázquez almost 5 years ago

  • Status changed from Closed to New
  • Resolution deleted (worksforme)

#5 Updated by Tino Vázquez almost 5 years ago

  • Assignee changed from Tino Vázquez to MIGUEL ANGEL ALVAREZ CABRERIZO

#6 Updated by Jaime Melis almost 5 years ago

  • Status changed from New to Assigned

#7 Updated by Miguel Ángel Álvarez Cabrerizo almost 5 years ago

  • Due date deleted (10/03/2016)
  • % Done changed from 100 to 10

Further testing shows the following behavior:

- Standalone VMDK files have no extension when uploaded to vCenter datastores. Extension is part of the name e.g smalltest*vmdk*
- GZipped standalone VMDK files has a hash as the name loosing original name and extension. e.g 3b595250c99fcf23a796bf0bcdcaad73. That hash is the same hash used as a name for the folder created in the datastore.
- Standalone and flat files inside a tar.gz works fine, original name and extension are preserved.

#8 Updated by Miguel Ángel Álvarez Cabrerizo over 4 years ago

  • % Done changed from 10 to 100

PR solves the following issues:

  • Uploading standalone vmdk file (uncompressed) looses vmdk file extension so vCenter can't browse it. Now a vmdk extension is added.
  • Uploading standalone vmdk file compressed with GZIP or BZIP2 changes file name to folder hash. Now a human readable name based on the original name and extension is added so it can be browsed.

Tested:
- Upload flat VMDk files in a tar.gz. OK
- Upload flat VMDk files in a tar.bz2. OK
- Upload flat VMDk files in a tar. OK
- Upload standalone VMDK file. OK
- Upload standalone VMDK file gzipped. OK
- Upload standalone VMDK file bzipped. OK
- Upload standalone VMDK file in a tar.gz. OK

#9 Updated by Miguel Ángel Álvarez Cabrerizo over 4 years ago

  • Due date set to 10/07/2016
  • Resolution set to fixed

#10 Updated by Miguel Ángel Álvarez Cabrerizo over 4 years ago

  • Status changed from Assigned to Closed

2016-10-07 PR Merged

Also available in: Atom PDF