Feature #4770

VNM 802.1Q GVRP support

Added by Kristian Feldsam about 4 years ago. Updated over 3 years ago.

Status:ClosedStart date:09/12/2016
Priority:HighDue date:
Assignee:Javi Fontan% Done:

0%

Category:Drivers - Network
Target version:Release 5.4
Resolution:fixed Pull request:

Description

Hello, would be fine, If we can tick checkbox to enable/disable GVRP when creating new network.

For now, I just added `gvrp on` to `ip link command` invoked by VNM.

I can do that, but I need more info about contributing code, especially how to setup development enviroment.

Associated revisions

Revision 880b838c
Added by Javi Fontan almost 4 years ago

F #4770: convert empty values into nil

This enables using options without value for ip link add command, for
example:

sudo ip link add lxcbr0.260  type vxlan id 260 group 239.0.101.4 \
ttl 16 dev lxcbr0 udp6zerocsumrx tos 10 udpcsum

In this command the parameters udp6zerocsumrx and udpcsum don't
have a parameter

Revision 2bc5ffe2
Added by Javi Fontan almost 4 years ago

F #4770: add ip link add options to 802.1Q and VXLAN

Conversion of true/false values is duplicated as these methods
could be also used by OpenvSwitch and it uses "true"/"false"
instead of "on"/"off".

Revision 9e0413a1
Added by Javi Fontan almost 4 years ago

F #3387, #4743, #4770: network conf documentation

History

#1 Updated by Ruben S. Montero about 4 years ago

Hi Kristian

I'm wondering if this setting makes sense per VM, VNET or driver; i.e.:

  • Driver, all VNETs created will have the same GVRP setting
  • VNET, all links created for VMs in this VNET will have the same GVRP
  • VM, just some of the links may have this and can be overwrite the VNET setting, if any

Cheers

#2 Updated by Kristian Feldsam about 4 years ago

Hello,

GVRP setting on|off have sense only in VNM and/or HOST. It has nothing to do with VMs, because on backgroud 802.1Q driver just create new vlan device and bridge on HOST.

#3 Updated by Kristian Feldsam about 4 years ago

So, it is per VNET and probably per HOST. I know, that we can set network driver, when we create new HOST node, but I don't know if it has some sense. I personally not define HOST network driver and just define VNETs

#4 Updated by Ruben S. Montero about 4 years ago

  • Tracker changed from Request to Backlog
  • Priority changed from Low to High
  • Target version changed from Release 5.2 to Release 5.4

#5 Updated by Javi Fontan almost 4 years ago

  • Assignee set to Javi Fontan

OK,

We are going to add a flexible way to include both ip link and brcrl options. We'll add the following to the VNET template:

BRIDGE_COMMANDS = [                                                                                                                                                  
   SETFS="76",                                                                                                                                                      
   STP = "ON" 
   ...       

IP_LINK_OPTIONS = [                                                                                                                                                     
   MUT=1550,                                                                                                                                                        
   GRVP = ON,
   ...                                                                                                                                                                                                                                                                                                                           

This way any parameter can be set at the admin level

#6 Updated by Javi Fontan over 3 years ago

  • Tracker changed from Backlog to Feature
  • Status changed from Pending to Closed
  • Resolution set to fixed

Documentation done.

Also available in: Atom PDF