Option to override TM_MAD's SHARED=[YES/NO] per datastore
|Category:||Drivers - Storage|
I am in a refactoring cycle for our addon and I am currently stuck at this situation:
The IMAGE_DS has TM_MAD named 'storpool' with attribute SHARED=YES in /etc/one/oned.conf
When the SYSTEM DS is of type `shared` everything is OK - datastore stats are reported in the DATASTORE tab.
When the SYSTEM_DS is set as `ssh` I've implemented two variants:
Variant A: use same TM_MAD as the IMAGE_DS but add additional datastore attribute to notify the driver to threat the datastore as ssh (even if the SHARED=YES in the TM_MAD)
Variant B: symlink the TM_MAD folder as different name and use it in second TM_MAD definition in /etc/one/oned.conf with SHARED=NO.
I've made variant B because in the case of variant A there are no datastore stats collected/reported in the HOST tab.
When there are two SYSTEM_DS defined - one with variant A(historical reasons) and one with variant B(to have stats) it is not possible to migrate VMs from one to another because the TM_MAD name differ.
I believe that making the SHARED attribute override-able per DS the issue could be easily solved. And in this case I'll use only one TM_MAD definition for both setups.
#4 Updated by Anton Todorov over 3 years ago
I honor your decision!
Just would like to note that addon already can work as different name but then it is not possible to change/migrate VM's SYSTEM datastores because the TM_MAD names differ :)
I think it is possible to workaround this constraint so it is not show stopper in any way.