Bug #5068
Warning dialog on VMsnapshot restore
| Status: | Closed | Start date: | 03/17/2017 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Abel Coronado | % Done: | 100% | |
| Category: | Sunstone | |||
| Target version: | - | |||
| Resolution: | fixed | Pull request: | ||
| Affected Versions: | OpenNebula 5.2 |
Description
Hi,
While playing with the VMsnapshots scripts [1] I've discovered that in the sunstone there is no warning dialog when restoring from snapshot.
As this operation is destroying the current VM I think a warning dialog is necessary (move the user one more click away from the disaster).
I've not checked the current code so excuse me for the noise if this issue is already coverd.
Kind Regards,
Anton Todorov
[1] Actually I am overriding the code to do only atomic snapshots on all VM disks at once as we still haven't libvirt integration yet, but I need "grouped" disk snapshots. And, the interface could be used as a workaround to #4008 and #4885 ;)
History
#1
Updated by OpenNebula Systems Support Team over 4 years ago
- Assignee set to Abel Coronado
#2
Updated by Abel Coronado over 4 years ago
- % Done changed from 0 to 100
#3
Updated by Ruben S. Montero over 4 years ago
- Status changed from Pending to Closed
- Resolution set to fixed
#4
Updated by Anton Todorov over 4 years ago
I it planned to backport to 5.2.x?
I've tried just applying the patch to 5.2.1. Patch succeeds but the dialog is not getting the sunstone_id properly leading to always revert to snapshot 0. If snapshot 0 is deleted an error is raised that there is no such snapshot.
the POST to openNebula is this json {"action":{"perform":"snapshot_revert","params":{}},"csrftoken":"49f664a713c1ab98012ca5ba620f9757"}
As you can see the `snapshot_id` parameter is totally missing.
I've added
console.log("snapshot_id:"+snapshot_id);
in the submit function and there snapshot_id is not defined.
No tested current master though.
Best Regards,
Anton Todorov
#5
Updated by Anton Todorov over 4 years ago
I've created a workaround which as stated in the PR is not perfect but works for me :)
https://github.com/OpenNebula/one/pull/244
I hope it will give you a glimpse on the issue so you can create proper fix for it.
Best Regards,
Anton Todorov