Bug #5329

Do not include both tm_common.sh and scripts_common.sh

Added by Christoph Pleger over 2 years ago. Updated over 2 years ago.

Status:ClosedStart date:08/29/2017
Priority:NormalDue date:
Assignee:Vlastimil Holer% Done:

0%

Category:Drivers - Storage
Target version:Release 5.4.3
Resolution:fixed Pull request:
Affected Versions:OpenNebula 5.4

Description

Hello,

some files in datastore/fs include both tm_common.sh and scripts_common.sh.
tm_common already includes scripts_common.sh; another include is not necessary
and even can cause errors, because scripts_common.sh adds option '-r' to $SED,
doing this twice makes sed fail.

(The problem with $SED does not occur when leaving scripts in datastore/fs as is,
but I added a few lines, including a call of fix_dir_slashes(), which calls $SED)

Regards
Christoph

Associated revisions

Revision 1fd938e4
Added by Vlastimil Holer over 2 years ago

B #5329: Remove duplicate loads of scripts_common.sh (#543)

Revision c9b91751
Added by Vlastimil Holer over 2 years ago

B #5329: Remove duplicate loads of scripts_common.sh (#543)

(cherry picked from commit 1fd938e49e7f84e8a90bb93901d6f698cd9a0a5f)

History

#1 Updated by Ruben S. Montero over 2 years ago

  • Category set to Drivers - Storage
  • Assignee set to Vlastimil Holer
  • Target version set to Release 5.4.3

#2 Updated by Ruben S. Montero over 2 years ago

  • Status changed from Pending to Closed
  • Resolution set to fixed

Also available in: Atom PDF