Bug #5393

VM snapshot revert/delete works with wrong snapshots

Added by Vlastimil Holer over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:09/25/2017
Priority:NormalDue date:
Assignee:Vlastimil Holer% Done:

0%

Category:Drivers - VM
Target version:Release 5.4.2
Resolution:fixed Pull request:
Affected Versions:OpenNebula 5.4

Description

VM snapshot revert/delete works on wrong snapshots due to change in libvirt snapshot names introduced in 5.4 by
https://github.com/OpenNebula/one/commit/226531e09de099fb5b03719f0809cbbaf46762a9#diff-ecebb684dfb32e5b557e02bbec3364c8L25
Before the change, the snapshot name was a UNIX time of the snapshot, a big enough number.

This is mainly old libvirt/qemu misbehavior
https://bugzilla.redhat.com/show_bug.cgi?id=733143
when simple numeric names are chosen for snapshot names. Names (tags) are then confused with snapshot IDs on qemu side, leading to revert to or delete(!) the wrong VM snapshot.

It's necessary to have snapshot names different to the simple snapshot IDs. Ideally, have snapshot names prefixed with a string (e.g. snap-123).

Associated revisions

Revision d8cc0fea
Added by Vlastimil Holer over 3 years ago

B #5393: Prefix libvirt snapshot name with snap- (#492)

libvirt/QEMU has problem with simple numberic names,
it's confused with the internal snapshot IDs:
https://bugzilla.redhat.com/show_bug.cgi?id=733143

Revision f7b4b98a
Added by Vlastimil Holer over 3 years ago

B #5393: Prefix libvirt snapshot name with snap- (#492)

libvirt/QEMU has problem with simple numberic names,
it's confused with the internal snapshot IDs:
https://bugzilla.redhat.com/show_bug.cgi?id=733143

(cherry picked from commit d8cc0fea13fc09420341645101034d1ea1076d2a)

History

#1 Updated by Vlastimil Holer over 3 years ago

  • Target version set to Release 5.4.2

#2 Updated by Vlastimil Holer over 3 years ago

  • Status changed from Pending to Closed
  • Resolution set to fixed

Also available in: Atom PDF