Bug #90
ACPI setting is inverted
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assignee: |  Tino Vázquez | % Done: | 100% | |
| Category: | Drivers - Auth | |||
| Target version: | Release 1.2.1 | |||
| Resolution: | fixed | Pull request: | ||
| Affected Versions: |
Description
Currently, you need to set "ACPI = no" to enable ACPI.
Presuming that ACPI should be on by default, the attached patch fixes the issue.
acpi-inverted.diff 
- Proposed fix
(1.85 KB)
acpi-inverted-off-by-default.diff
(490 Bytes)
Associated revisions
Now KVM driver gets acpi and pae default settings from the driver configuration file (#90)
git-svn-id: http://svn.opennebula.org/one/branches/one-1.2@478 3034c82b-c49b-4eb3-8279-a7acafdc01c0
Added default values to KVM driver (#90)
git-svn-id: http://svn.opennebula.org/one/branches/one-1.2@479 3034c82b-c49b-4eb3-8279-a7acafdc01c0
Changes for #90 (acpi and pae values) applied to trunk
git-svn-id: http://svn.opennebula.org/one/trunk@480 3034c82b-c49b-4eb3-8279-a7acafdc01c0
History
#1
Updated by Redmine Admin over 12 years ago
I'm holding off on uploading this patch to Ubuntu before I get your feedback on whether ACPI should be on or off by default. It would be unfortunate to diverge.
#2
Updated by Tino Vázquez over 12 years ago
- Status changed from New to Assigned
#3
Updated by Redmine Admin over 12 years ago
If you want to go with ACPI off by default, the attached patch should do the trick.
#4
Updated by Tino Vázquez over 12 years ago
By default, ACPI should be on.
#5
Updated by Ruben S. Montero about 12 years ago
- Update vmm_kvm.conf to add the new supported defaults
- Add a suitable default value for ACPI in the vmm_kvm.conf file
- The documentation should be updated to reflect that PAE and ACPI can be set in the vmm_kvm.conf. Probably the Optional Attributes section is the best place to do that.
This should be included in trunk/development documentation also
#6
Updated by Javi Fontan about 12 years ago
- % Done changed from 0 to 80
Testing and documentation needs to be done before closing this issue.
#7
Updated by Javi Fontan about 12 years ago
- % Done changed from 80 to 90
- Resolution set to fixed
Testing and documentation for trunk done. We need to make sure that the documentation is updated for 1.2 just before releasing 1.2.1.
#8
Updated by Tino Vázquez almost 12 years ago
- Status changed from Assigned to Closed
- % Done changed from 90 to 100
Documentation updated. Closing.