Bug #1002

move mkfs-dependant option "-F" from tm_mkimage.sh to fs/mkfs-script

Added by Jochem Ippers over 9 years ago. Updated over 9 years ago.

Status:ClosedStart date:11/23/2011
Priority:NormalDue date:
Assignee:Jaime Melis% Done:

0%

Category:Drivers - Auth
Target version:Release 3.2
Resolution:fixed Pull request:
Affected Versions:OpenNebula 3.2

Description

Hi,
this is just a minimal one: I wanted to use the xfs filesystem on datablock-disks, and so I added a new IM-driver set of scripts copied from /var/lib/one/remotes/image/fs/ and added a new case-esac branch for xfs in the script mkfs:

    "xfs") 
        OPTS="" 
        ;;

But the creation of the datablock failed with the message "mkfs.xfs: invalid option -- 'F'". The reason for this is that this option is contained in the mkfs command call in the tm_mkimage.sh scripts:
exec_and_log "$MKFS -t $FSTYPE -F $DST_PATH"

But as the option -F is filesystem dependent it should probably be moved into the different mkfs-branches of the fs/mkfs script.

Kind regards.
Jochem

Associated revisions

Revision 40a65441
Added by Jaime Melis over 9 years ago

Bug #1002: move mkfs-dependant option "-F" from tm_mkimage.sh to fs/mkfs-script

History

#1 Updated by Ruben S. Montero over 9 years ago

  • Tracker changed from Request to Bug
  • Target version changed from Release 3.4 to Release 3.2
  • Affected Versions OpenNebula 3.2 added

Thanks for the feedback.

I've classified this as bug and schedule for next release

#2 Updated by Ruben S. Montero over 9 years ago

  • translation missing: en.field_story_points set to 0

#3 Updated by Ruben S. Montero over 9 years ago

  • Status changed from New to Assigned
  • Assignee set to Jaime Melis

#4 Updated by Jaime Melis over 9 years ago

  • Status changed from Assigned to Closed
  • Resolution set to fixed

Created a common function in scripts_common.sh, which is available both to mkfs and tm_mkimage.sh, that returns the mkfs command.

Also available in: Atom PDF