Bug #1252

LDAP authentication issue on password characters

Added by olivier sallou over 7 years ago. Updated over 7 years ago.

Status:ClosedStart date:04/23/2012
Priority:NormalDue date:
Assignee:Javi Fontan% Done:

0%

Category:Drivers - Auth
Target version:Release 3.6
Resolution:fixed Pull request:
Affected Versions:OpenNebula 3.4

Description

I faced recently a password identification issue with LDAP users depending on password.

I could fix the issue in /usr/lib/one/mads/one_auth_mad.rb with this patch:

--- one_auth_mad.rb.orig    2012-04-23 13:54:13.000000000 0200
+
+ one_auth_mad.rb 2012-04-23 13:50:22.000000000 +0200
@ -110,7 +110,8 @
authN_path = File.join(@local_scripts_path, driver)
command = File.join(authN_path, ACTION[:authN].downcase)
- command << " '" << user.gsub("'", '\'"\'"\'') << "' '" << password.gsub("'", '\'"\'"\'') << "' " << secret
+ #command << " '" << user.gsub("'", '\'"\'"\'') << "' '" << password.gsub("'", '\'"\'"\'') << "' " << secret
+ command << " '" << user.gsub("'", '\'"\'"\'') << "' '" << password.gsub("'", '\'"\'"\'') << "' '" << secret << "'"
rc = LocalCommand.run(command, log_method(request_id))

Adding quotesbefore and after secret. This may not be enough though. secret may indeed get quotes too. Certainly it would need the same kind of qsub than on password

Associated revisions

Revision ad9b4937
Added by Javi Fontan over 7 years ago

bug #1252: escape auth parameters

Revision 9a34feec
Added by Javi Fontan over 7 years ago

features #1236 and #1252: bug fixes

Revision be639816
Added by Javi Fontan over 7 years ago

features #1236 and #1252: move unescape to ldap auth

Revision e5d6e2c8
Added by Javi Fontan over 7 years ago

features #1236 and #1252: make URI escape work with ruby 1.8.7

History

#1 Updated by Ruben S. Montero over 7 years ago

  • Category set to Drivers - Auth
  • Assignee set to Javi Fontan
  • Target version set to Release 3.6

#2 Updated by Javi Fontan over 7 years ago

  • Status changed from New to Closed
  • Resolution set to fixed

Also available in: Atom PDF