OpenNebula

This patch does not seem to work really well to me. I deletes the second part of the variable:

$ echo $VAR
tap2:tap

$ echo ${VAR%%:*}
tap2

$ echo ${VAR%:*}
tap2

I'd use this other version:

$ echo $VAR2
tap2:aio:

$ echo ${VAR%:}
tap2:tap

$ echo ${VAR2%:}
tap2:aio

Hi Javi,

You're right. I've just noticed that too while doing some more testing. In fact, I wrote it like you first.
Then I came up with the idea to remove any colon at the end of $DRIVER (phy:: -> phy).

But the "%%" combined with "*" has the following effect according to bash man page : "If parameter is @ or *, the pattern removal operation is applied to each positional parameter in turn, and the expansion is the resultant list."

This is not what I intended, I should have tested with "tap2:aio:" first :-(

So, as long as the user has not mis-encoded the DRIVER variable (which is another problem), your version is OK.

Cheers,

Laurent

I've added the trailing space safeguard for all prefixes, just to be on the safe side. The default prefix is still not changed, I want to check with my colleagues but seems fine to me to change it.

Thanks for the patch and tips!