Bug #2386

Log backup in /usr/bin/one is incomplete & inefficient

Added by Bill Cole over 7 years ago. Updated over 7 years ago.

Status:ClosedStart date:10/14/2013
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Core & System
Target version:Release 4.4
Resolution:fixed Pull request:
Affected Versions:OpenNebula 4.2

Description

The 'one' script only backs up oned.log, leaving one_xmlrpc.log to grow forever and allowing sched.log to be clobbered by the new mm_sched process. In addition, by using 'cp' instead of 'mv' to create a renamed log, it does more work than needed and risks a disk space problem.

The attached patch adds backup of those additional logs with mv, moves the backups from start() into start_one() and start_sched(), and exposes the fact that the *_sched commands are supported in the "Usage" message.

onepatch.txt Magnifier - patch for /usr/bin/one script (1.72 KB) Bill Cole, 10/15/2013 06:01 PM

Associated revisions

Revision c1d3f625
Added by Bill Cole over 7 years ago

Bug #2386: Better log backup for one start

Backup all log files with mv, move the backups from start() into start_one() and start_sched(), and expose the fact that the *_sched commands are supported

Revision 81821ec5
Added by Bill Cole over 7 years ago

Bug #2386: Better log backup for one start

Backup all log files with mv, move the backups from start() into start_one() and start_sched(), and expose the fact that the *_sched commands are supported

(cherry picked from commit c1d3f62543a0df3bd04658d7b4672f1345e8abec)

History

#1 Updated by Ruben S. Montero over 7 years ago

  • Category set to Core & System
  • Status changed from Pending to New
  • Target version set to Release 4.4

#2 Updated by Carlos Martín over 7 years ago

  • Status changed from New to Closed
  • Resolution set to fixed

Thanks a lot Bill, your patch will be included in the final 4.4 release.

Also available in: Atom PDF