Bug #4087
VM - Create button text when an error occurs
| Status: | Closed | Start date: | 10/23/2015 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Carlos Martín | % Done: | 0% | |
| Category: | Sunstone | |||
| Target version: | Release 4.14.2 | |||
| Resolution: | fixed | Pull request: | ||
| Affected Versions: | OpenNebula 4.14 |
Description
When creating a new VM, the text of the create button change from "Create" to "Submitting..." . But if an error occurs during the allocation of the new VM, the create button text remains "Submitting..." instead of reverting to "Create". Despite this, clicking on "Submitting..." create the new VM.
Associated revisions
Bug #4087: Reset forms on error
Bug #4087: Reset forms on error
(cherry picked from commit acb4719009ce58be8d0640d1b9b3bda5f8a90636)
History
#1
Updated by Ruben S. Montero over 5 years ago
- Target version set to Release 4.14.2
#2
Updated by Carlos Martín over 5 years ago
- Status changed from Pending to New
- Assignee set to Carlos Martín
- Resolution set to fixed
Fixed, thank you!
#3
Updated by Carlos Martín over 5 years ago
- Status changed from New to Closed
#4
Updated by Rolandas Naujikas over 5 years ago
I just installed from source this change and it looks it doesn't work as expected.
When I create new VM from a template, then button text stays as Submitting... after error occurs.
#5
Updated by Carlos Martín over 5 years ago
Hi,
How did you test it?
Did you create a new installation, or did you instead apply this patch to your current installation?
In order to use the non-minified JS files sunstone must be configured to use the development environment:
http://docs.opennebula.org/4.14/integration/references/compile.html#building-sunstone-from-source
#6
Updated by Rolandas Naujikas over 5 years ago
Carlos Martín wrote:
Hi,
How did you test it?
Did you create a new installation, or did you instead apply this patch to your current installation?
I'm creating new installation to empty directory with script
export PATH=$HOME/node_modules/.bin:$PATH rm -rf ~/.npm ~/node_modules npm install bower npm install grunt npm install grunt-cli wget -qNP /var/tmp http://XXX/opennebula/opennebula-4.14.1.tar.gz rm -rf /var/tmp/opennebula-4.14.1 tar xzf /var/tmp/opennebula-4.14.1.tar.gz -C /var/tmp cd /var/tmp/opennebula-4.14.1 ( cd src/sunstone/public && npm install && bower install ) scons sqlite=yes mysql=yes new_xmlrpc=no sunstone=yes ./install.sh -d /var/lib/one/4.14.1 -p # http://dev.opennebula.org/issues/4039 cp -f src/sunstone/public/images/opennebula-sunstone-v4.14-small.png /var/lib/one/4.14.1/lib/sunstone/public/images/
http://XXX/opennebula/opennebula-4.14.1.tar.gz is a place, where I put source from git repository.
I checked additionally, it contains changes from revision dc8d0e6a.
In order to use the non-minified JS files sunstone must be configured to use the development environment:
http://docs.opennebula.org/4.14/integration/references/compile.html#building-sunstone-from-source
#7
Updated by Rolandas Naujikas over 5 years ago
I retested just now with fresh git clone from branch one-4.14 and it works.
Probably *.js was cached in browser. Sorry for disturbing.
#8
Updated by Carlos Martín over 5 years ago
No problem, thank you for testing it.